Replace payloaders with parsers and adjust tests to new timestamp generation #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Noarkhh
commented
Sep 1, 2023
Noarkhh
commented
- Replace Payloaders with Parsers
- Adjust tests to new timestamp generation in H264.Parser
Noarkhh
force-pushed
the
update-to-new-formats
branch
from
0340c48 to
6d56476
Compare
varsill
reviewed
Sep 4, 2023
| attach_nalus?: true, | ||
| skip_until_parameters?: false | ||
| case {encoding, profile} do | ||
| {:H264, :constrained_baseline} -> |
There was a problem hiding this comment.
You can consider adding:
Suggested change
| {:H264, :constrained_baseline} -> | |
| @non_b_frames_profiles [:constrained_baseline, :baseline] | |
| ... | |
| {:H264, profile} when profile in @non_b_frames_profiles -> |
varsill
approved these changes
Sep 4, 2023
mix.exs
Outdated
Comment on lines
70
to
74
| # {:membrane_h264_plugin, "~> 0.7.1"}, | ||
| {:membrane_h264_plugin, | ||
| github: "membraneframework/membrane_h264_plugin", | ||
| branch: "pass-framerate-to-output-format", | ||
| override: true}, |
There was a problem hiding this comment.
Just remember to fix it once the plugin is released
varsill
approved these changes
Sep 4, 2023
mat-hek
approved these changes
Sep 6, 2023
Karolk99
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.